Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix log line for fingerprint not found #13555

Merged
merged 1 commit into from
Jul 17, 2024

Conversation

salvacorts
Copy link
Contributor

What this PR does / why we need it:
This log line was misleading since It’s printing the series.Fingerprint which is what the iterator returns, not fp what is what we seek for.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@salvacorts salvacorts marked this pull request as ready for review July 17, 2024 11:14
@salvacorts salvacorts requested a review from a team as a code owner July 17, 2024 11:14
@salvacorts salvacorts merged commit aeb23bb into main Jul 17, 2024
62 checks passed
@salvacorts salvacorts deleted the salvacorts/fix-logline-fuse-querier branch July 17, 2024 11:21
@salvacorts salvacorts added type/bug Somehing is not working as expected backport k211 labels Jul 17, 2024
grafanabot pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport k211 size/XS type/bug Somehing is not working as expected
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants