fix(operator): Set object storage for delete requests when using retention #13562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
periklis
approved these changes
Jul 17, 2024
periklis
pushed a commit
to periklis/loki
that referenced
this pull request
Jul 17, 2024
periklis
pushed a commit
to periklis/loki
that referenced
this pull request
Jul 17, 2024
periklis
pushed a commit
to periklis/loki
that referenced
this pull request
Jul 17, 2024
periklis
added a commit
to openshift/loki
that referenced
this pull request
Jul 17, 2024
[release-5.9] Backport PR for grafana#13562
periklis
added a commit
to openshift/loki
that referenced
this pull request
Jul 17, 2024
[release-5.6] Backport PR for grafana#13562
periklis
added a commit
to openshift/loki
that referenced
this pull request
Jul 17, 2024
[release-5.8] Backport PR for grafana#13562
This was referenced Aug 15, 2024
This was referenced Oct 14, 2024
This was referenced Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Loki 3.1 requires a new option in the compactor configuration when retention is enabled. If the option is missing, the configuration will fail validation and Loki does not start. This affects all components, not just the compactor.
This PR adds the new configuration option when retention is enabled.
Which issue(s) this PR fixes:
Fixes LOG-5821
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)