Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(blooms): Cleanup temp blockdir in bloom compactor #13622

Merged
merged 1 commit into from
Jul 23, 2024
Merged

fix(blooms): Cleanup temp blockdir in bloom compactor #13622

merged 1 commit into from
Jul 23, 2024

Conversation

chaudum
Copy link
Contributor

@chaudum chaudum commented Jul 23, 2024

What this PR does / why we need it:

A follow up to #13522
This PR fixes the missing cleanup function call to remove temporary blocks from the filesystem.

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@chaudum
fix(blooms): Cleanup temp blockdir in bloom compactor
a032377 
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
@chaudum chaudum requested a review from a team as a code owner July 23, 2024 08:57
poyzannur
poyzannur approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@poyzannur poyzannur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one lgtm

@chaudum chaudum added the type/bug Somehing is not working as expected label Jul 23, 2024
@chaudum chaudum merged commit 64215e1 into main Jul 23, 2024
63 checks passed
@chaudum chaudum deleted the chaudum/fix-temp-block-cleanup-compactor branch July 23, 2024 09:25
This was referenced Aug 15, 2024
Open
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 9, 2024
Merged
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 23, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Sep 30, 2024
Open
@loki-gh-app loki-gh-app bot mentioned this pull request Oct 7, 2024
Open
This was referenced Oct 14, 2024
Open
Closed
This was referenced Oct 21, 2024
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@salvacorts salvacorts salvacorts approved these changes

@poyzannur poyzannur poyzannur approved these changes

Assignees
No one assigned
Labels
size/S type/bug Somehing is not working as expected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@chaudum @salvacorts @poyzannur