Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loki mixin: alert and recording rules make range interval configurable #13630

Closed
jmichalek132 opened this issue Jul 23, 2024 · 0 comments · Fixed by #13925
Closed

Loki mixin: alert and recording rules make range interval configurable #13630

jmichalek132 opened this issue Jul 23, 2024 · 0 comments · Fixed by #13925
Labels
component/mixin type/feature Something new we should do

Comments

@jmichalek132
Copy link
Contributor

Is your feature request related to a problem? Please describe.

In our case we have scrape interval of 1m, however one alert and recording rules in the mixin seem to have hardcoded range interval, examples:
https://github.com/grafana/loki/blob/main/production/loki-mixin/alerts.libsonnet#L10
https://github.com/grafana/loki/blob/main/production/loki-mixin/recording_rules.libsonnet#L8

Describe the solution you'd like

Have a config option for the range interval window in alerts, similar to what is already present for recording rules in mimir mixin and loki mixin. https://github.com/grafana/mimir/blob/main/operations/mimir-mixin/config.libsonnet#L674.

Describe alternatives you've considered
Manually editing the alerts after they are rendered, which kind of defeats the point of mixins imho.

Additional context
https://www.robustperception.io/what-range-should-i-use-with-rate/

As I have raised PRs to fix this in mimir & tempo I can do the same for loki.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/mixin type/feature Something new we should do
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants