fix(blooms): Improve error wrap to make ignoreNotFound work when fetching blocks #13656
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Fix an issue where the
options.ignoreNotFound
of the fetcher is not effective.The root cause of this issue is that the error returned by
fmt.Errorf()
inBloomClient
loses the underlying cause. As a result,S3ObjectClient.IsObjectNotFoundErr()
fails to determine if the underlying cause of the returned error is of typeawserr.Error
.https://github.com/grafana/loki/blob/2dfc13bb73c73c6c8cfb57c23ce832f902d8a43e/pkg/storage/chunk/client/aws/s3_storage_client.go#L498C1-L504C2
Which issue(s) this PR fixes:
Special notes for your reviewer:
Checklist
CONTRIBUTING.md
guide (required)feat
PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.md
production/helm/loki/Chart.yaml
and updateproduction/helm/loki/CHANGELOG.md
andproduction/helm/loki/README.md
. Example PRdeprecated-config.yaml
anddeleted-config.yaml
files respectively in thetools/deprecated-config-checker
directory. Example PR