Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Applying patterns line length limit on the json message key #13984

Closed
cyriltovena opened this issue Aug 28, 2024 · 1 comment · Fixed by #14296
Closed

Applying patterns line length limit on the json message key #13984

cyriltovena opened this issue Aug 28, 2024 · 1 comment · Fixed by #14296

Comments

@cyriltovena
Copy link
Contributor

cyriltovena commented Aug 28, 2024

We drop lines that are too big default 3k chars or contains too many tokens for performance reasons in pattern ingesters.

For json log line we only use a set of keys for discovering patterns.

We could probably do the json message parsing prior that limit and apply that limit on the message key.

Notes:

  • We should avoid parsing the json key twice.
  • This might means we'll hold the backing array for the log buffer entirely and increase memory usage.
@ravishankar15
Copy link
Contributor

Hi @cyriltovena Correct me if my understanding is wrong, Basically if its a jsonTokenizer we wanted to check MaxAllowedLineLength on the extracted line from the set of keys that is after Tokenize. For other tokenizers it should proceed as it is now ?

Can you help with the clarification. I can raise a PR for this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants