Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Rename mispelled filename #14237

Merged
merged 8 commits into from
Sep 25, 2024
Merged

fix: Rename mispelled filename #14237

merged 8 commits into from
Sep 25, 2024

Conversation

jhuizingh
Copy link
Contributor

@jhuizingh jhuizingh commented Sep 24, 2024

What this PR does / why we need it:

Just fixing a misspelled filename.

No documentation changes needed. Helm will hydrate the files in the templates directory regardless of the file name and changing the filename does not modify what the contents of the file will generate.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@jhuizingh jhuizingh requested a review from a team as a code owner September 24, 2024 00:05
@CLAassistant
Copy link

CLAassistant commented Sep 24, 2024

CLA assistant check
All committers have signed the CLA.

@jhuizingh jhuizingh changed the title Rename mispelled filename fix: Rename mispelled filename Sep 24, 2024
@trevorwhitney
Copy link
Collaborator

Thanks for the contribution, just a few conflicts to resolve and I can shepard the build and get it merged.

@jhuizingh
Copy link
Contributor Author

Glad to do it! I think I have the conflicts resolved. Thanks for the review.

@trevorwhitney trevorwhitney merged commit cf1d4a3 into grafana:main Sep 25, 2024
65 checks passed
LashaJini pushed a commit to LashaJini/loki that referenced this pull request Sep 26, 2024
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
jeschkies pushed a commit to jeschkies/loki that referenced this pull request Oct 1, 2024
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
mraboosk pushed a commit to mraboosk/loki that referenced this pull request Oct 7, 2024
Co-authored-by: Trevor Whitney <trevorjwhitney@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants