Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: missing dep PartitionRing for Ingester #14292

Merged

Conversation

grobinson-grafana
Copy link
Contributor

@grobinson-grafana grobinson-grafana commented Sep 27, 2024

What this PR does / why we need it:

This pull request fixes a bug in loki.go where ingesters depend on PartitionRing, but we forgot to add it as a dependency in deps.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • For Helm chart changes bump the Helm chart version in production/helm/loki/Chart.yaml and update production/helm/loki/CHANGELOG.md and production/helm/loki/README.md. Example PR
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@grobinson-grafana grobinson-grafana self-assigned this Sep 27, 2024
@grobinson-grafana grobinson-grafana requested a review from a team as a code owner September 27, 2024 11:03
@grobinson-grafana grobinson-grafana changed the title Fix missing dep PartitionRing for Ingester fix: missing dep PartitionRing for Ingester Sep 27, 2024
@grobinson-grafana grobinson-grafana merged commit 6354ded into main Sep 27, 2024
63 checks passed
@grobinson-grafana grobinson-grafana deleted the grobinson/fix-missing-deps-partition-ingester branch September 27, 2024 11:13
jeschkies pushed a commit to jeschkies/loki that referenced this pull request Oct 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants