Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(kafka): Start ingester flush loop before trying to catch up from Kafka #14505

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

benclive
Copy link
Contributor

What this PR does / why we need it:

Starts the flush loop before starting the kafka catch up logic.

  • This avoids a scenario where we are catching up after a long outage/backlog and we aren't flushing chunks, which leads to OOM after a while.
  • With the flush loop running, the ingester will be flushing new data as chunks fill up and we shouldn't OOM (as quickly!)

Which issue(s) this PR fixes:
Fixes https://github.com/grafana/loki-private/issues/1149

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

@benclive benclive requested a review from a team as a code owner October 16, 2024 16:06
Copy link
Contributor

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benclive benclive merged commit 524ed81 into main Oct 17, 2024
62 checks passed
@benclive benclive deleted the start-flush-loop-before-partition-reader branch October 17, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants