Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(operator): correctly ignore again BlotDB dashboards #14587

Merged
merged 1 commit into from
Oct 23, 2024

Conversation

JoaoBraveCoding
Copy link
Collaborator

BoltDB dashboards had been removed in #11022 however they were renamed which broke our ignore.
See:
#13022
#12788

What this PR does / why we need it:

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Checklist

  • Reviewed the CONTRIBUTING.md guide (required)
  • Documentation added
  • Tests updated
  • Title matches the required conventional commits format, see here
    • Note that Promtail is considered to be feature complete, and future development for logs collection will be in Grafana Alloy. As such, feat PRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.
  • Changes that require user attention or interaction to upgrade are documented in docs/sources/setup/upgrade/_index.md
  • If the change is deprecating or removing a configuration option, update the deprecated-config.yaml and deleted-config.yaml files respectively in the tools/deprecated-config-checker directory. Example PR

BoltDB dashboards had been removed in grafana#11022
however they were renamed which broke our ignore.
See:
grafana#13022
grafana#12788
@periklis periklis merged commit 4879d10 into grafana:main Oct 23, 2024
70 checks passed
periklis pushed a commit to periklis/loki that referenced this pull request Oct 24, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Oct 24, 2024
openshift-merge-bot bot added a commit to openshift/loki that referenced this pull request Oct 24, 2024
openshift-merge-bot bot added a commit to openshift/loki that referenced this pull request Oct 24, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Oct 24, 2024
periklis pushed a commit to periklis/loki that referenced this pull request Oct 24, 2024
periklis added a commit to openshift/loki that referenced this pull request Oct 24, 2024
@JoaoBraveCoding JoaoBraveCoding deleted the fix-dashboards branch November 8, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants