fix(blooms): Fix check for skipping most recent data when filtering blooms #15300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After changing the default of `-bloom-build.planner.min-table-offset` from `1` (yesterday) to `0` (today), we noticed that the bloom gateways reported a very high percentage of missing series in blocks. This is because the gateway received filter requests for today's block, but the requested series is too new and has not been added to the bloom block yet. In the bloom querier on the index gateway there is a condition under which requests to the bloom gateway are skipped, because the blooms are likely not available yet. This PR changes this condition to correctly take the min-table-offset as well as the planning-interval into account. Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
Signed-off-by: Christian Haudum <christian.haudum@gmail.com>
|
This PR must be merged before a backport PR will be created. |
loki-gh-app bot
pushed a commit
that referenced
this pull request
Dec 6, 2024
…looms (#15300) After changing the default of `-bloom-build.planner.min-table-offset` from `1` (yesterday) to `0` (today), we noticed that the bloom gateways reported a very high percentage of missing series in blocks. This is because the gateway received filter requests for today's block, but the requested series is too new and has not been added to the bloom block yet. In the bloom querier on the index gateway there is a condition under which requests to the bloom gateway are skipped, because the blooms are likely not available yet. This PR changes this condition to correctly take the min-table-offset as well as the planning-interval into account. Signed-off-by: Christian Haudum <christian.haudum@gmail.com> (cherry picked from commit 78d3c44)
Merged
6 tasks
This was referenced Dec 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
After changing the default of
-bloom-build.planner.min-table-offsetfrom1(yesterday) to0(today), we noticed that the bloom gateways reported a very high percentage of missing series in blocks.This is because the gateway received filter requests for today's block, but the requested series is too new and has not been added to the bloom block yet.
In the bloom querier on the index gateway there is a condition under which requests to the bloom gateway are skipped, because the blooms are likely not available yet.
This PR changes this condition to correctly take the min-table-offset as well as the planning-interval into account.
Special notes for your reviewer:
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mddeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR