Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(lambda-promtail): Add terraform variable for s3 bucket notification filter prefix #15381

Merged

Conversation

milenpankov-bosch
Copy link
Contributor

@milenpankov-bosch milenpankov-bosch commented Dec 12, 2024

What this PR does / why we need it: Exposes the filter_prefix in the lambda_function of the aws_s3_bucket_notification resource as a terraform variable.

Which issue(s) this PR fixes:
Fixes #15380

@milenpankov-bosch milenpankov-bosch requested a review from a team as a code owner December 12, 2024 06:42
@CLAassistant
Copy link

CLAassistant commented Dec 12, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@chaudum chaudum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@chaudum chaudum changed the title lambda-promtail: add terraform variable for s3 bucket notification filter prefix feat(lambda-promtail): Add terraform variable for s3 bucket notification filter prefix Dec 12, 2024
@chaudum chaudum merged commit 3dd8d7d into grafana:main Dec 12, 2024
60 checks passed
mveitas pushed a commit to mveitas/loki that referenced this pull request Jan 6, 2025
…ion filter prefix (grafana#15381)

Exposes the filter_prefix in the lambda_function of the aws_s3_bucket_notification resource as a terraform variable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

lambda-promtail: add terraform variable for s3 bucket notification filter prefix
3 participants