-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(lambda-promtail): Remove s3 bucket ownership verification #15383
Merged
chaudum
merged 8 commits into
grafana:main
from
milenpankov-bosch:lambda-promtail-remove-s3-ownership-verification
Dec 23, 2024
Merged
fix(lambda-promtail): Remove s3 bucket ownership verification #15383
chaudum
merged 8 commits into
grafana:main
from
milenpankov-bosch:lambda-promtail-remove-s3-ownership-verification
Dec 23, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chaudum
reviewed
Dec 12, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Otherwise LGTM
chaudum
changed the title
lambda-promtail: remove s3 bucket ownership verification
fix(lambda-promtail): Remove s3 bucket ownership verification
Dec 12, 2024
chaudum
reviewed
Dec 12, 2024
Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
chaudum
approved these changes
Dec 23, 2024
This was referenced Dec 30, 2024
mveitas
pushed a commit
to mveitas/loki
that referenced
this pull request
Jan 6, 2025
…a#15383) Co-authored-by: Christian Haudum <christian.haudum@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it: Removes the s3 bucket ownership verification as it is not using an AWS account id for verification.
Which issue(s) this PR fixes:
Fixes #15382