Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document frontend worker #1867

Closed
owen-d opened this issue Mar 30, 2020 · 2 comments · Fixed by #1873
Closed

Document frontend worker #1867

owen-d opened this issue Mar 30, 2020 · 2 comments · Fixed by #1873
Assignees

Comments

@owen-d
Copy link
Member

owen-d commented Mar 30, 2020

Trying to answer #1863 I realized we don't have docs relating to the frontend worker (used when we run the query-frontend+queriers in grpc mode)

We should document the frontend worker configs

// WorkerConfig is config for a worker.
type WorkerConfig struct {
	Address           string
	Parallelism       int
	DNSLookupDuration time.Duration

	GRPCClientConfig grpcclient.Config `yaml:"grpc_client_config"`
}
@adityacs
Copy link
Contributor

@owen-d Also, this is little confusing https://github.com/cortexproject/cortex/blob/12b15b9b2ecb36029e8f4330b4e2c01e7f180619/pkg/querier/frontend/frontend.go#L51

In Loki context, we should say it should be downstream querier/Loki URL

@owen-d
Copy link
Member Author

owen-d commented Mar 30, 2020

haha good point

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants