Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI Linter seems to not catch all errors. #2767

Closed
cyriltovena opened this issue Oct 15, 2020 · 2 comments
Closed

CI Linter seems to not catch all errors. #2767

cyriltovena opened this issue Oct 15, 2020 · 2 comments
Labels
stale A stale issue or PR that will automatically be closed.

Comments

@cyriltovena
Copy link
Contributor

I'm seeing a diff locally. Fixing what I can see but the CI should be fixed.
@cyriltovena
Copy link
Contributor Author

/cc @owen-d @sandeepsukhani Make sure to lint locally before pushing PR.

@cyriltovena cyriltovena mentioned this issue Oct 15, 2020
Merged
@stale
Copy link

stale bot commented Nov 14, 2020

This issue has been automatically marked as stale because it has not had any activity in the past 30 days. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Nov 14, 2020
@stale stale bot closed this as completed Nov 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
stale A stale issue or PR that will automatically be closed.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@cyriltovena