Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit dropped streams #4797

Closed
cyriltovena opened this issue Nov 22, 2021 · 1 comment · Fixed by #5334
Closed

Limit dropped streams #4797

cyriltovena opened this issue Nov 22, 2021 · 1 comment · Fixed by #5334
Assignees
Labels
type/enhancement Something existing could be improved

Comments

@cyriltovena
Copy link
Contributor

cyriltovena commented Nov 22, 2021

The dropped streams list is unbounded see

func (t *tailer) blockedSince() *time.Time {

This means a slow receiver can have this list to grow infinitely and this can increase the memory usage on the ingester side, specially if the label-set is big (e.g from parsing label with json)

See ingester memory for example:

image

I suggest we only keep the last 10 dropped streams.

@cyriltovena cyriltovena added the type/enhancement Something existing could be improved label Nov 22, 2021
@stale
Copy link

stale bot commented Jan 9, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Jan 9, 2022
@stale stale bot removed the stale A stale issue or PR that will automatically be closed. label Feb 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Something existing could be improved
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants