Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add regex label selection to pack stage to allow packing whole groups of labels #4987

Closed
frittentheke opened this issue Dec 21, 2021 · 2 comments
Labels
stale A stale issue or PR that will automatically be closed.

Comments

@frittentheke
Copy link
Contributor

Is your feature request related to a problem? Please describe.
While it's possible to apply regex matching during relabeling (https://grafana.com/docs/loki/latest/clients/promtail/scraping/#relabeling) to rename a group of metadata labels (e.g. __meta_kubernetes_* or __journal_*) in order from them to be kept, this configuration approach is not yet possible for the pack stage.

Currently the pack stage (#3401) only accepts a static list of labels via the labels option for them to be packed into the message. (https://grafana.com/docs/loki/latest/clients/promtail/stages/pack/#pack-stage-schema). To copy all metadata from e.g. __kubernetes, it's required to know, provide and maintain the full list of all those labels in order for them to be packed with the message.

Also when extracting / parsing a nice set of all prefixed labels (e.g. myprefix_) which can then just all be packed into the message with no additional configuration for each new label would be a great addition.

Describe the solution you'd like

Add support for regex pattern, just like for relabeling (https://grafana.com/docs/loki/latest/clients/promtail/scraping/#relabeling) to allow flexible selection of groups of labels and their sub-strings. This should work like with the labelmap action (relabeling):

      - action: labelmap
        regex: __meta_kubernetes_pod_label_(.+)

Describe alternatives you've considered

Additional context
It might make sense to align this capability for the labeldrop and labelkeep stages as well.

@stale
Copy link

stale bot commented Mar 2, 2022

Hi! This issue has been automatically marked as stale because it has not had any
activity in the past 30 days.

We use a stalebot among other tools to help manage the state of issues in this project.
A stalebot can be very useful in closing issues in a number of cases; the most common
is closing issues or PRs where the original reporter has not responded.

Stalebots are also emotionless and cruel and can close issues which are still very relevant.

If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry.

We regularly sort for closed issues which have a stale label sorted by thumbs up.

We may also:

  • Mark issues as revivable if we think it's a valid issue but isn't something we are likely
    to prioritize in the future (the issue will still remain closed).
  • Add a keepalive label to silence the stalebot if the issue is very common/popular/important.

We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task,
our sincere apologies if you find yourself at the mercy of the stalebot.

@stale stale bot added the stale A stale issue or PR that will automatically be closed. label Mar 2, 2022
@stale stale bot closed this as completed Apr 18, 2022
@Daniel-Vaz
Copy link
Contributor

I also have a need for this feature.
Is there any workaround ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale A stale issue or PR that will automatically be closed.
Projects
None yet
Development

No branches or pull requests

2 participants