Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add readiness handlers to distributor and querier modules #504

Closed
sboschman opened this issue Apr 23, 2019 · 5 comments · Fixed by #848 or #854
Closed

Add readiness handlers to distributor and querier modules #504

sboschman opened this issue Apr 23, 2019 · 5 comments · Fixed by #848 or #854
Labels
component/packaging good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! type/feature Something new we should do

Comments

@sboschman
Copy link
Contributor

Is your feature request related to a problem? Please describe.
Currently only the ingester has a readiness handler (https://github.com/grafana/loki/blob/master/pkg/loki/modules.go#L148). If you deploy the three Loki components (distributor, ingester and querier) separately not all of them have a readiness handler to use as Kubernetes readiness/liveness probe paths. For the querier the path /api/prom/label could be used as readiness/liveness path. The readiness/liveness probes for the distributor had to be disabled though.

Describe the solution you'd like
Separate ready handlers for all three modules.

@cyriltovena cyriltovena added component/packaging type/feature Something new we should do labels Apr 24, 2019
@jan25
Copy link

jan25 commented May 25, 2019

@Kuqd would you know if someone is already working on this? Otherwise i'm happy to take a look

@cyriltovena
Copy link
Contributor

Nobody is feel free to take it.

@cyriltovena cyriltovena added good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! labels Aug 1, 2019
@cyriltovena cyriltovena pinned this issue Aug 1, 2019
@adityacs
Copy link
Contributor

adityacs commented Aug 2, 2019

@cyriltovena I would like to take this.

@jan25
Copy link

jan25 commented Aug 2, 2019

@adityacs I couldn't work on this. Go ahead!

@cyriltovena
Copy link
Contributor

Please do ! I pinned the issue because we need this rather sooner than later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/packaging good first issue These are great first issues. If you are looking for a place to start, start here! help wanted We would love help on these issues. Please come help us! type/feature Something new we should do
Projects
None yet
4 participants