-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[loki-canary] fully configurable query #5747
Comments
Hi! This issue has been automatically marked as stale because it has not had any We use a stalebot among other tools to help manage the state of issues in this project. Stalebots are also emotionless and cruel and can close issues which are still very relevant. If this issue is important to you, please add a comment to keep it open. More importantly, please add a thumbs-up to the original issue entry. We regularly sort for closed issues which have a We may also:
We are doing our best to respond, organize, and prioritize all issues but it can be a challenging task, |
@dannykopping @slim-bean can you review this issue and tell me if it is feasible to implement? |
@pgassmann apologies for the poor comms here! It seems to me that we could replace the existing 4 arguments (
I can't see much value in keeping each of the existing 4 arguments as individual fields since we hardly use them separately (expect for https://github.com/grafana/loki/blob/main/pkg/canary/reader/reader.go#L419 AFAICS) What do you think @slim-bean? |
Is your feature request related to a problem? Please describe.
loki-canary needs a single label which uniquely identify its logs. This is not always the case if loki-canary is deployed on multiple hosts or namespaces.
Also, the message cannot be packed inside a json (e.g. from Pipeline pack or from vector.dev json encoding.
Describe the solution you'd like
it would be nice if we could configure a custom LogQL query instead of the fixed selectors. (label, stream).
Log QL Query
{category="dockerlogs", host="logserver1", container_name="loki-canary", source="stdout"} | json | line_format "{{.message}}"
Describe alternatives you've considered
Additional context
Example log message format when using vector.dev Loki sink with encoding=json
Related: #1435 #2259
The text was updated successfully, but these errors were encountered: