-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Promtail: Support CRI-O multi-lines #5854
Comments
While working on PR to support Created a bug report here.cri-o/cri-o#5903 |
I think may be I misunderstood the purpose of log tags in |
Yes correct. After 8192 bytes per line. Check also this issue cri-o/cri-o#4432 |
Is also described a bit here: cri-o/cri-o#4432 Nevertheless it would be very helpful to fix this issue, because a single line stack trace, which is over 8192 bytes long, is split by cri-o and ends up in Loki with several log lines. If the application already creates a multi line stack strace, I think you can solve it this way: We even sometimes have the case that multiple log lines are subjected to the 8192 limit and are split: cri-o/cri-o#4432 (comment), here it would also help a lot if Promtail could join the fragmented messages. |
It turns out that the split can theoretically happen at any position of a log line: cri-o/cri-o#4432 (comment) |
Is your feature request related to a problem? Please describe.
Promtail has top-level support for CRI-O logs using the cri stage. However, this does not support multi-line CRI-O logs.
Describe the solution you'd like
The
cri
stage just handles multi-lines.Describe alternatives you've considered
A custom
multiline
step. This is possible but thecri
step removes some of the log tags so it doesn't work in conjunction.Additional context
CRI-O has two log tags,
P
indicating a partial logline (one that will be continued by another partial logline, or by a 'full log line'), andF
indicating a full logline.Also, Fluent Bit already supports this. The documentation is here with some additional context in the feature request.
The text was updated successfully, but these errors were encountered: