New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid TLSConfig in promtail and loki #777

Closed

slim-bean opened this issue Jul 18, 2019 · 1 comment · Fixed by #778

Collaborator

slim-bean commented Jul 18, 2019

loki/cmd/logcli/client.go

Lines 68 to 74 in 2f46a3c

    
           TLSConfig: config.TLSConfig{ 
        
           	CAFile:             *tlsCACertPath, 
        
           	CertFile:           *tlsClientCertPath, 
        
           	KeyFile:            *tlsClientCertKeyPath, 
        
           	ServerName:         url, 
        
           	InsecureSkipVerify: *tlsSkipVerify, 
        
           },

ServerName should just be the hostname and not the full url

Collaborator Author

slim-bean commented Jul 18, 2019

Note: this occurs in more than one place

slim-bean mentioned this issue

Fix logcli TLS config to use proper server name #778

Merged

cyriltovena closed this as completed in #778

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment