New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ingester panic in tailing code #942

Closed

slim-bean opened this issue Aug 27, 2019 · 0 comments · Fixed by #986

Assignees

Collaborator

slim-bean commented Aug 27, 2019

loki/pkg/ingester/tailer.go

Line 125 in 481906c

case t.sendChan <- &stream:

Looks like it might be a race between the check for the tailer isClosed at the beginning of the function and the send to the channel towards the end?

cyriltovena assigned sandeepsukhani

pracucci mentioned this issue

Fix panic in tailer due to race condition between send() and close() #986

Merged

2 tasks

cyriltovena closed this as completed in #986

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment