Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

split_queries_by_interval on wrong place in config #9688

Closed
bumarcell opened this issue Jun 12, 2023 · 4 comments
Closed

split_queries_by_interval on wrong place in config #9688

bumarcell opened this issue Jun 12, 2023 · 4 comments
Labels
type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories

Comments

@bumarcell
Copy link

According to Query Frontend docu, the config split_queries_by_interval should be in the yaml config under query_range.
It appears, however, it es being templated under limits_config

Do I have a misunderstanding here?

Regards

@jimmymjin
Copy link

jimmymjin commented Jun 13, 2023

In 2.5.0 split_queries_by_interval can only be defined in the limits_config section, Loki will fail to start if you do not remove the split_queries_by_interval config from the query_range section.
reference: https://grafana.com/docs/loki/latest/upgrading/#250

BTW, the new default value of 30m didn't work for me, I changed it to 24h to fix "too many outstanding requests" issue mentioned here: #5123

@chaudum chaudum added the type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories label Jun 14, 2023
@chaudum
Copy link
Contributor

chaudum commented Jun 14, 2023

Hi @bumarcell You are right, the paragraph about parallelization is incorrect. The correct place to put the split_queries_by_interval is the limits_config as @jimmymjin pointed out.

@chaudum
Copy link
Contributor

chaudum commented Jun 14, 2023

Additionally the CLI flag argument may be confusing as well, since it has the prefix -querier. Unfortunately, this cannot be changed easily. The setting is a per-tenant setting.

@bumarcell
Copy link
Author

Alright, thanks for clarification 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/docs Issues related to technical documentation; the Docs Squad uses this label across many repositories
Projects
None yet
Development

No branches or pull requests

3 participants