feat: add recalculateOwnedStreams to check stream ownership if the ring is changed #13103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re recalculating owned streams; `go mod tidy && go mod vendor`; update ingester tests Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
… is at the ingester level now; update tests Signed-off-by: JordanRushing <rushing.jordan@gmail.com>
JordanRushing
commented
Jun 6, 2024
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
…r-limit # Conflicts: # pkg/ingester/instance_test.go
Signed-off-by: Vladyslav Diachenko <vlad.diachenko@grafana.com>
github-actions
bot
added
the
type/docs
vlad-diachenko
changed the title
go mod tidy && go mod vendor; update ingester tests
JordanRushing
commented
Jun 13, 2024
JordanRushing
commented
Jun 13, 2024
JordanRushing
commented
Jun 13, 2024
JordanRushing
commented
Jun 13, 2024
I would keep these two files separately. that said, we can find better names for it ))) let's discuss it next week and rename it afterward |
|
merging it to have these changes included in the next weekly release. |
7 tasks
7 tasks
This was referenced Jul 3, 2024
Closed
JordanRushing
added a commit
to JordanRushing/loki
that referenced
this pull request
Jul 15, 2024
Ingester stream limits now take into account "owned streams" and periodically update when the Ingester ring is changed. Non-owned streams are now also flushed when this update takes place. The stream limit calculation has also been updated for improved accuracy in multi-zone ingester deployments. Relevant PRs: - grafana#13006 - grafana#13030 - grafana#13232 - grafana#13103 - grafana#13231 - grafana#13254 - grafana#13314 - grafana#13321
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
re:
This PR adds a
recalculateOwnedStreamsservice to ingesters which periodically polls in the ingester ring and updates the owned stream counts of each instance.When Loki ingesters are auto-scaled and run in a zone-aware configuration adding replicas to an ingester statefulset can cause inadvertent stream limiting until old streams are flushed from memory. Using a new limiter that dynamically determines owned streams helps to solve this issue.
Which issue(s) this PR fixes:
N/A
Special notes for your reviewer:
N/A
Checklist
CONTRIBUTING.mdguide (required)featPRs are unlikely to be accepted unless a case can be made for the feature actually being a bug fix to existing behavior.docs/sources/setup/upgrade/_index.mdproduction/helm/loki/Chart.yamland updateproduction/helm/loki/CHANGELOG.mdandproduction/helm/loki/README.md. Example PRdeprecated-config.yamlanddeleted-config.yamlfiles respectively in thetools/deprecated-config-checkerdirectory. Example PR