Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Commit 02f4007

Browse files
authored
Merge pull request #572 from raintank/better-0-reqs-behavior
reqs with 0 series: fix metrics and msgp responses
2 parents a7681c5 + 6e4b1ba commit 02f4007

File tree

1 file changed

+9
-3
lines changed

1 file changed

+9
-3
lines changed

api/graphite.go

+9-3
Original file line numberDiff line numberDiff line change
@@ -263,13 +263,19 @@ func (s *Server) renderMetrics(ctx *middleware.Context, request models.GraphiteR
263263
}
264264
}
265265

266+
reqRenderSeriesCount.Value(len(reqs))
267+
reqRenderTargetCount.Value(len(request.Targets))
268+
266269
if len(reqs) == 0 {
267-
response.Write(ctx, response.NewJson(200, []string{}, ""))
270+
if request.Format == "msgp" {
271+
var series models.SeriesByTarget
272+
response.Write(ctx, response.NewMsgp(200, series))
273+
} else {
274+
response.Write(ctx, response.NewJson(200, []string{}, ""))
275+
}
268276
return
269277
}
270278

271-
reqRenderSeriesCount.Value(len(reqs))
272-
reqRenderTargetCount.Value(len(request.Targets))
273279
if (toUnix - fromUnix) >= logMinDur {
274280
log.Info("HTTP Render: INCOMING REQ %q from: %q, to: %q target cnt: %d, maxDataPoints: %d",
275281
ctx.Req.Method, from, to, len(request.Targets), request.MaxDataPoints)

0 commit comments

Comments
 (0)