add tests

Author: Dieterbe

api/query_engine_test.go

@@ -414,6 +414,28 @@ func TestAlignRequestsHuh(t *testing.T) {
 	)
 }
 
+func TestAlignRequestsDifferentReadyStates(t *testing.T) {
+	testAlign([]models.Req{
+		reqRaw(test.GetMKey(1), 100, 300, 800, 1, consolidation.Avg, 0, 0),
+	},
+		[][]conf.Retention{
+			{
+				conf.NewRetentionMT(1, 300, 120, 5, 0),              // TTL not good enough
+				conf.NewRetentionMT(5, 450, 600, 4, math.MaxUint32), // TTL good, but not ready
+				conf.NewRetentionMT(10, 460, 600, 3, 150),           // TTL good, but not ready since long enough
+				conf.NewRetentionMT(20, 470, 600, 2, 101),           // TTL good, but not ready since long enough
+				conf.NewRetentionMT(60, 480, 600, 1, 100),           // TTL good and ready since long enough
+			},
+		},
+		[]models.Req{
+			reqOut(test.GetMKey(1), 100, 300, 800, 1, consolidation.Avg, 0, 0, 4, 60, 480, 60, 1),
+		},
+		nil,
+		500,
+		t,
+	)
+}
+
 var hour uint32 = 60 * 60
 var day uint32 = 24 * hour
 

conf/retention_test.go

@@ -0,0 +1,62 @@
+package conf
+
+import (
+	"math"
+	"reflect"
+	"testing"
+)
+
+func TestParseRetentions(t *testing.T) {
+	cases := []struct {
+		in  string
+		err bool
+		out []Retention
+	}{
+		{
+			in:  "1s:1d:1h:2,1m:8d:4h:2:1234567890,10m:120d:6h:1:true,30m:2y:6h:1:false",
+			err: false,
+			out: []Retention{
+				{
+					SecondsPerPoint: 1,
+					NumberOfPoints:  24 * 3600,
+					ChunkSpan:       60 * 60,
+					NumChunks:       2,
+					Ready:           0,
+				},
+				{
+					SecondsPerPoint: 60,
+					NumberOfPoints:  8 * 24 * 3600 / 60,
+					ChunkSpan:       4 * 60 * 60,
+					NumChunks:       2,
+					Ready:           1234567890,
+				},
+				{
+					SecondsPerPoint: 600,
+					NumberOfPoints:  120 * 24 * 3600 / 600,
+					ChunkSpan:       6 * 60 * 60,
+					NumChunks:       1,
+					Ready:           0,
+				},
+				{
+					SecondsPerPoint: 30 * 60,
+					NumberOfPoints:  2 * 365 * 24 * 3600 / (30 * 60),
+					ChunkSpan:       6 * 60 * 60,
+					NumChunks:       1,
+					Ready:           math.MaxUint32,
+				},
+			},
+		},
+	}
+	for i, c := range cases {
+		got, err := ParseRetentions(c.in)
+		if (err != nil) != c.err {
+			t.Fatalf("case %d: exp error %t but got err %v", i, c.err, err)
+		}
+		if c.err {
+			continue
+		}
+		if !reflect.DeepEqual(Retentions(c.out), got) {
+			t.Fatalf("case %d: exp retentions\n%v\nbut got\n%v", i, c.out, got)
+		}
+	}
+}