Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Commit b38778c

Browse files
committed
remove tilde from name values when indexing tags
1 parent ca45c6b commit b38778c

File tree

5 files changed

+33
-9
lines changed

5 files changed

+33
-9
lines changed

Gopkg.lock

+2-2
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Gopkg.toml

+1-1
Original file line numberDiff line numberDiff line change
@@ -111,7 +111,7 @@ unused-packages = true
111111

112112
[[constraint]]
113113
name = "github.com/raintank/schema"
114-
revision = "5611429bd204bf26a3de166316cf3cad0de377c9"
114+
revision = "4338db1233d0ebaa44a7523061c8f37e65d2868c"
115115

116116
[[constraint]]
117117
name = "github.com/rs/cors"

idx/memory/memory.go

+4-4
Original file line numberDiff line numberDiff line change
@@ -478,7 +478,7 @@ func (m *UnpartitionedMemoryIdx) indexTags(def *schema.MetricDefinition) {
478478
tagValue := tagSplits[1]
479479
tags.addTagId(tagName, tagValue, def.Id)
480480
}
481-
tags.addTagId("name", def.Name, def.Id)
481+
tags.addTagId("name", def.NameSanitizedAsTagValue(), def.Id)
482482

483483
m.defByTagSet.add(def)
484484
}
@@ -504,7 +504,7 @@ func (m *UnpartitionedMemoryIdx) deindexTags(tags TagIndex, def *schema.MetricDe
504504
tags.delTagId(tagName, tagValue, def.Id)
505505
}
506506

507-
tags.delTagId("name", def.Name, def.Id)
507+
tags.delTagId("name", def.NameSanitizedAsTagValue(), def.Id)
508508

509509
m.defByTagSet.del(def)
510510

@@ -890,7 +890,7 @@ func (m *UnpartitionedMemoryIdx) FindTagValues(orgId uint32, tag, prefix string,
890890

891891
// special case if the tag to complete values for is "name"
892892
if tag == "name" {
893-
valueMap[def.Name] = struct{}{}
893+
valueMap[schema.SanitizeNameAsTagValue(def.Name)] = struct{}{}
894894
} else {
895895
for _, t := range def.Tags {
896896
if !strings.HasPrefix(t, prefix) {
@@ -1275,7 +1275,7 @@ func (m *UnpartitionedMemoryIdx) DeleteTagged(orgId uint32, paths []string) ([]i
12751275
continue
12761276
}
12771277
expressions := elements[1:]
1278-
expressions = append(expressions, "name="+elements[0])
1278+
expressions = append(expressions, "name="+schema.SanitizeNameAsTagValue(elements[0]))
12791279

12801280
q, err := NewTagQuery(expressions, 0)
12811281
if err != nil {

idx/memory/tag_query.go

+2-2
Original file line numberDiff line numberDiff line change
@@ -571,7 +571,7 @@ func (q *TagQuery) testByMatch(def *idx.Archive, exprs []kvRe, not bool) bool {
571571
EXPRS:
572572
for _, e := range exprs {
573573
if e.key == "name" {
574-
if e.value == nil || e.value.MatchString(def.Name) {
574+
if e.value == nil || e.value.MatchString(schema.SanitizeNameAsTagValue(def.Name)) {
575575
if not {
576576
return false
577577
} else {
@@ -696,7 +696,7 @@ func (q *TagQuery) testByFrom(def *idx.Archive) bool {
696696
func (q *TagQuery) testByPrefix(def *idx.Archive, exprs []kv) bool {
697697
EXPRS:
698698
for _, e := range exprs {
699-
if e.key == "name" && strings.HasPrefix(def.Name, e.value) {
699+
if e.key == "name" && strings.HasPrefix(schema.SanitizeNameAsTagValue(def.Name), e.value) {
700700
continue EXPRS
701701
}
702702

vendor/github.com/raintank/schema/metric.go

+24
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)