Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Commit bec3e7c

Browse files
committed
fix sortByName calls
in grafana, if you add them manually, it's without quotes in graphite docs, is also without quotes (http://graphite.readthedocs.io/en/latest/functions.html#graphite.render.functions.sortByName) MT doesn't support booleans like that: ~/g/s/g/g/metrictank ❯❯❯ ./build/mt-explain "sortByName(foo, 'true')" ⏎ Error while planning argument bad type. expected string - got etString ~/g/s/g/g/metrictank ❯❯❯ ./build/mt-explain "sortByName(foo, true)" Plan: * Exprs: expr-func sortByName( expr-target "foo", HUH-SHOULD-NEVER-HAPPEN, ) * Reqs: {foo 1517332946 1517419346 NoneConsolidator} MaxDataPoints: 800 From: 1517332946 To: 1517419346
1 parent adc3176 commit bec3e7c

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

dashboard.json

+3-3
Original file line numberDiff line numberDiff line change
@@ -521,7 +521,7 @@
521521
"targets": [
522522
{
523523
"refId": "A",
524-
"target": "sortByName(aliasByNode(metrictank.stats.$environment.$instance.cluster.notifier.kafka.partition.*.lag.gauge64, 3, 8), 'true')"
524+
"target": "sortByName(aliasByNode(metrictank.stats.$environment.$instance.cluster.notifier.kafka.partition.*.lag.gauge64, 3, 8), true)"
525525
}
526526
],
527527
"thresholds": [],
@@ -591,7 +591,7 @@
591591
"targets": [
592592
{
593593
"refId": "A",
594-
"target": "sortByName(aliasByNode(metrictank.stats.$environment.$instance.input.kafka-mdm.partition.*.lag.gauge64, 3, 7), 'true')"
594+
"target": "sortByName(aliasByNode(metrictank.stats.$environment.$instance.input.kafka-mdm.partition.*.lag.gauge64, 3, 7), true)"
595595
}
596596
],
597597
"thresholds": [],
@@ -1171,7 +1171,7 @@
11711171
"targets": [
11721172
{
11731173
"refId": "A",
1174-
"target": "aliasByNode(sortByName(sumSeriesWithWildcards(perSecond(metrictank.stats.$environment.$instance.api.request.*.status.*.counter32), 3), 'true'), 5, 7)"
1174+
"target": "aliasByNode(sortByName(sumSeriesWithWildcards(perSecond(metrictank.stats.$environment.$instance.api.request.*.status.*.counter32), 3), true), 5, 7)"
11751175
}
11761176
],
11771177
"thresholds": [],

0 commit comments

Comments
 (0)