Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Commit fa2b2f0

Browse files
committed
BenchmarkAggregate: also test with 2 input series, and test using Min
so that we can better see the effect of #1164
1 parent 36065b4 commit fa2b2f0

File tree

1 file changed

+10
-1
lines changed

1 file changed

+10
-1
lines changed

expr/func_aggregate_test.go

+10-1
Original file line numberDiff line numberDiff line change
@@ -272,6 +272,9 @@ func testAggregate(name, agg string, in [][]models.Series, out models.Series, t
272272
func BenchmarkAggregate10k_1NoNulls(b *testing.B) {
273273
benchmarkAggregate(b, 1, test.RandFloats10k, test.RandFloats10k)
274274
}
275+
func BenchmarkAggregate10k_2NoNulls(b *testing.B) {
276+
benchmarkAggregate(b, 2, test.RandFloats10k, test.RandFloats10k)
277+
}
275278
func BenchmarkAggregate10k_10NoNulls(b *testing.B) {
276279
benchmarkAggregate(b, 10, test.RandFloats10k, test.RandFloats10k)
277280
}
@@ -285,6 +288,9 @@ func BenchmarkAggregate10k_1000NoNulls(b *testing.B) {
285288
func BenchmarkAggregate10k_1SomeSeriesHalfNulls(b *testing.B) {
286289
benchmarkAggregate(b, 1, test.RandFloats10k, test.RandFloatsWithNulls10k)
287290
}
291+
func BenchmarkAggregate10k_2SomeSeriesHalfNulls(b *testing.B) {
292+
benchmarkAggregate(b, 2, test.RandFloats10k, test.RandFloatsWithNulls10k)
293+
}
288294
func BenchmarkAggregate10k_10SomeSeriesHalfNulls(b *testing.B) {
289295
benchmarkAggregate(b, 10, test.RandFloats10k, test.RandFloatsWithNulls10k)
290296
}
@@ -298,6 +304,9 @@ func BenchmarkAggregate10k_1000SomeSeriesHalfNulls(b *testing.B) {
298304
func BenchmarkAggregate10k_1AllSeriesHalfNulls(b *testing.B) {
299305
benchmarkAggregate(b, 1, test.RandFloatsWithNulls10k, test.RandFloatsWithNulls10k)
300306
}
307+
func BenchmarkAggregate10k_2AllSeriesHalfNulls(b *testing.B) {
308+
benchmarkAggregate(b, 2, test.RandFloatsWithNulls10k, test.RandFloatsWithNulls10k)
309+
}
301310
func BenchmarkAggregate10k_10AllSeriesHalfNulls(b *testing.B) {
302311
benchmarkAggregate(b, 10, test.RandFloatsWithNulls10k, test.RandFloatsWithNulls10k)
303312
}
@@ -324,7 +333,7 @@ func benchmarkAggregate(b *testing.B, numSeries int, fn0, fn1 func() []schema.Po
324333
b.ResetTimer()
325334
var err error
326335
for i := 0; i < b.N; i++ {
327-
f := NewAggregateConstructor("average", crossSeriesAvg)()
336+
f := NewAggregateConstructor("min", crossSeriesMin)()
328337
avg := f.(*FuncAggregate)
329338
avg.in = append(avg.in, NewMock(input))
330339
results, err = f.Exec(make(map[Req][]models.Series))

0 commit comments

Comments
 (0)