Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

streaming processing and series limiting on other cluster calls #1092

Closed
Dieterbe opened this issue Oct 11, 2018 · 4 comments
Closed

streaming processing and series limiting on other cluster calls #1092

Dieterbe opened this issue Oct 11, 2018 · 4 comments
Labels

Comments

@Dieterbe
Copy link
Contributor

Dieterbe commented Oct 11, 2018

#1021 introduced streaming processing and series limiting for clusterFindByTag

findSeries (which does a similar thing but for non-tagged queries) should get the same changes.

we should probably also switch these to stream processing:
clusterTagDetails, clusterTags, clusterAutoCompleteTags, clusterAutoCompleteTagValues

@shanson7 @woodsaj not sure if my memory is failing me, but i just realized spec-exec is implented for all the above calls, but not for actually getting data (getTargets). what's the reasoning for this? have we discussed this before? seems we should also switch this over to peerQuerySpeculativeChan

@Dieterbe
Copy link
Contributor Author

eventually we should be able to delete peerQuerySpeculative and just use peerQuerySpeculativeChan

@shanson7
Copy link
Collaborator

shanson7 commented Oct 11, 2018

I believe the reason we don't do speculative execution for getTargets is that those requests target a subset of peers (just the ones that had matching series) and each peer gets a different request.

It could still do speculative execution, it would just look a bit different and might be harder to pick a threshold, since a variable number of peers are involved.

@woodsaj
Copy link
Member

woodsaj commented Oct 28, 2018

I think #1104 is relevant to this discussion

@stale
Copy link

stale bot commented Apr 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 4, 2020
@stale stale bot closed this as completed Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants