Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

target-type and unit #173

Closed
Dieterbe opened this issue Mar 11, 2016 · 2 comments
Closed

target-type and unit #173

Dieterbe opened this issue Mar 11, 2016 · 2 comments

Comments

@Dieterbe
Copy link
Contributor

@woodsaj re 7f94953
note that target-type and unit are mandatory in metrics2.0
they help in auto-selecting applicable aggregation/consolidation methods (we're not going to keep doing all aggregations for all series when we can deduce that only a few are needed based on the type) as well as setting good defaults for viz.
unit should also be useful down the road to automatically set the right unit in grafana (once grafana gets some metrics2.0 support)
I think now would be a great time to make sure all metrics coming in have the needed metadata set.

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Apr 1, 2016

@woodsaj see reasoning above. can we make these two tags mandatory again?

@Dieterbe
Copy link
Contributor Author

fixed in #250

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant