This repository has been archived by the owner on Aug 23, 2023. It is now read-only.

go-nsq allocates too much memory in DecodeMessage and ReadResponse #187

Closed

Dieterbe opened this issue Apr 1, 2016 · 1 comment

Assignees

Contributor

Dieterbe commented Apr 1, 2016

about 50% of our allocations are in the go-nsq consumer
requires an upstream fix nsqio/go-nsq#174

this should make our GC runs about half as frequent

woodsaj assigned Dieterbe

Contributor Author

Dieterbe commented Apr 17, 2016

I fixed the worst offender (DecodeMessage) via nsqio/go-nsq#175

ReadResponse is harder to do and it looks like not worth our time, since we're moving to kafka soon.

Dieterbe closed this as completed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.