Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

time to set up vendoring #197

Closed
Dieterbe opened this issue Apr 19, 2016 · 3 comments
Closed

time to set up vendoring #197

Dieterbe opened this issue Apr 19, 2016 · 3 comments

Comments

@Dieterbe
Copy link
Contributor

we should more tightly control which dependencies we build against.
case in point: i just spent a day QA'ing a release and forgot to build against the latest go-nsq library with my -30% allocation patch :( ), but also to prevent accidentally pulling in breaking changes.

we can even just pull in the actual code, so resist deps going offline. as long as go get doesn't pull those deps twice (once in vendor dir, once because it sees the import)

i've been looking at the glide tool for this, but there's a few different ones.

@Dieterbe
Copy link
Contributor Author

Dieterbe commented May 5, 2016

i didn't like glide. govendor makes a lot more sense to me.

@Dieterbe
Copy link
Contributor Author

@woodsaj I would like to just use govendor and store a copy of all dependencies in the vendor folder. this makes MT easily go-gettable as well. any objections?

@woodsaj
Copy link
Member

woodsaj commented Jul 26, 2016

No objection from me.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants