Skip to content
This repository was archived by the owner on Aug 23, 2023. It is now read-only.

Failed to submit event to accounting, channel was blocked #942

Closed
Dieterbe opened this issue Jun 13, 2018 · 5 comments
Closed

Failed to submit event to accounting, channel was blocked #942

Dieterbe opened this issue Jun 13, 2018 · 5 comments
Labels

Comments

@Dieterbe
Copy link
Contributor

Dieterbe commented Jun 13, 2018

seeing these in prod sometimes.

  1. we should make sure that queue fill is much less likely to happen (e.g. via batched operations instead of singular AddChunk calls)
  2. we should probably make the queue blocking, and not drop messages. I haven't studied the code well enough yet, but it seems current behavior can make the bookkeeping out of touch with reality, which is bad. I rather block cache operations for several ms.
@Dieterbe
Copy link
Contributor Author

related: should we do evictions/deletions in batches? we can optimize CCacheMetric.Del that way.

@Dieterbe
Copy link
Contributor Author

Dieterbe commented Jun 18, 2018

AddRange and HitChunks implemented via #943

@Dieterbe
Copy link
Contributor Author

we have seen some issues in prod where the cache metrics looked strange/unreliable

@Dieterbe
Copy link
Contributor Author

the last TODO here is probably just evictions/deletions in batches. we can optimize CCacheMetric.Del

@stale
Copy link

stale bot commented Apr 4, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale label Apr 4, 2020
@stale stale bot closed this as completed Apr 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

1 participant