Changes to make screens more responsive + incident status toggler change #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hContext, linting
…, fixed table responsiveness in alert groups
teodosii
added
the
pr:no public docs
teodosii
changed the title
teodosii
commented
Feb 2, 2023
| const handleDateChange = useCallback( | ||
| (date: Date) => { | ||
| onChange({ selectedDate: moment(date).format('YYYY-MM-DD') }); | ||
| const SchedulesFilters = (props: SchedulesFiltersProps) => { |
There was a problem hiding this comment.
Hmm, I haven't touched these parts. Don't know why these changes show up in here
These show up as changes because
- Old files of
Schedules_NEWwere moved intoSchedules - Did minor changes to rendering
maskin25
suggested changes
Feb 2, 2023
|
|
maskin25
approved these changes
Feb 2, 2023
brojd
pushed a commit
that referenced
this pull request
Sep 18, 2024
…nge (#1237) # What this PR does - Changes to make a few screens be more responsive - Removed incident actions and replaced incident status with a toggler - Renamed `IncidentStatus.new` to `IncidentStatus.Firing` - Removed old schedules code (unused) ## Which issue(s) this PR fixes #1000 ## Checklist - [x] `CHANGELOG.md` updated --------- Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
IncidentStatus.newtoIncidentStatus.FiringWhich issue(s) this PR fixes
#1000
Checklist
CHANGELOG.mdupdated