Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance page is deprecated, info message was added #2497

Merged
merged 6 commits into from
Jul 12, 2023

Conversation

Ukochka
Copy link
Contributor

@Ukochka Ukochka commented Jul 11, 2023

What this PR does

Maintenance page is deprecated, info message was added

closes https://github.com/grafana/oncall-private/issues/1737

@Ukochka Ukochka added pr:no changelog pr:no public docs Added to a PR that does not require public documentation updates labels Jul 11, 2023
@Ukochka Ukochka requested a review from a team July 11, 2023 12:05
Copy link
Contributor

@joeyorlando joeyorlando left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Tested locally, going to merge in as this is a pre-requisite for #2511. I added a note to the changelog as some users might wonder what happened to this page (just a note for next time).

@joeyorlando joeyorlando merged commit df0ce35 into dev Jul 12, 2023
@joeyorlando joeyorlando deleted the 1737-teamselector-for-maintanence branch July 12, 2023 10:11
brojd pushed a commit that referenced this pull request Sep 18, 2024
# What this PR does
Maintenance page is deprecated, info message was added

closes grafana/oncall-private#1737

---------

Co-authored-by: Joey Orlando <joey.orlando@grafana.com>
Co-authored-by: Joey Orlando <joseph.t.orlando@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr:no public docs Added to a PR that does not require public documentation updates
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants