Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escalation step "Continue escalation if current time is in range" doesn't work correctly #2781

Closed
Ferril opened this issue Aug 11, 2023 · 1 comment

Comments

@Ferril
Copy link
Member

Ferril commented Aug 11, 2023

What went wrong?

What happened:
The escalation step's wording says that it uses UTC timezone. In PUT request on updating time range and in escalation logs I can see that the time range for this step is different than I selected in the step settings.
Screenshot 2023-08-11 at 13 16 27

Screenshot 2023-08-11 at 13 16 55

How do we reproduce it?

  1. Set non-UTC local timezone
  2. Create escalation step "Continue escalation if current time is in range"
  3. Select time range in local timezone, that doesn't cover current time
  4. Send demo alert in any integration using escalation chain with this step
  5. Check escalation timeline

Grafana OnCall Version

r213-v1.3.23

Product Area

Alert Flow & Configuration

Grafana OnCall Platform?

I use Grafana Cloud

User's Browser?

No response

Anything else to add?

No response

@Ferril Ferril added the bug Something isn't working label Aug 11, 2023
@matiasb
Copy link
Contributor

matiasb commented Aug 16, 2023

FWIW, besides the UI and logs mentioning expected UTC times, public API also expects UTC values for from/to.

As noted, the conversion is being done in the frontend before pushing the data, so I think we should disable this TZ conversion there and be consistent with the expectations everywhere else (or alternatively, make sure to display in the UI which is the timezone assumed before the conversion).

FTR, this is also reported here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants