Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Slack notifications when override changed but schedule was not affected #294

Closed
summerwollin opened this issue Jul 26, 2022 · 1 comment
Closed
Labels
bug Something isn't working

Comments

@summerwollin
Copy link

summerwollin commented Jul 26, 2022

Context: https://raintank-corp.slack.com/archives/C0229FD3CE9/p1658852803728199

Many overrides were created within a couple minutes of each other that did not change the on-call schedule in order to preserve our rotation calendar as we are about to add another person to the rotation. This caused the on-call app to post to slack with notifications about shift changes even though who was on-call for each shift remained the same. The notifications were only for the current week's shifts so it was 4 notifications for the 4 days left in the shifts.

Possible solutions would be to either not display a message at all if it is the same as previous or add a line indicating an override has changed but the current shifts are not affected

@summerwollin summerwollin added the bug Something isn't working label Jul 26, 2022
@matiasb
Copy link
Contributor

matiasb commented Jun 15, 2023

This should have been fixed by #2080.

@matiasb matiasb closed this as completed Jun 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants