Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stretch goal but the sooner the better] Investigate non-regression snapshot tests #248

Closed
Tracked by #192
fridgepoet opened this issue Sep 1, 2023 · 1 comment
Closed
Tracked by #192

[stretch goal but the sooner the better] Investigate non-regression snapshot tests #248

fridgepoet opened this issue Sep 1, 2023 · 1 comment
Assignees
@fridgepoet
Labels
effort/small

Comments

@fridgepoet
Copy link
Member

fridgepoet commented Sep 1, 2023 •
edited
Loading

Investigate if creating tests like grafana/grafana#59312 that were used in grafana/grafana#54011 should be added to OpenSearch.

Edit:

Observations:

  • These can provide non-regression tests as we continue to add/refactor our code, but only in the backend.
  • It does not compare frontend/backend data frames
  • Helps us be aware of any changes we make in the backend.
  • Recommended adding a readme/guide for how to add tests.
@fridgepoet fridgepoet mentioned this issue Sep 1, 2023
Closed
@fridgepoet fridgepoet changed the title stretch goal but the sooner the better: Add non-regression snapshot tests to the backend to ensure that changes to the backend during backend development will be detected [stretch goal but the sooner the better Add non-regression snapshot tests to the backend to ensure that changes to the backend during backend development will be detected Sep 1, 2023
@fridgepoet fridgepoet changed the title [stretch goal but the sooner the better Add non-regression snapshot tests to the backend to ensure that changes to the backend during backend development will be detected [stretch goal but the sooner the better] Add non-regression snapshot tests to the backend to ensure that changes to the backend during backend development will be detected Sep 1, 2023
@fridgepoet fridgepoet changed the title [stretch goal but the sooner the better] Add non-regression snapshot tests to the backend to ensure that changes to the backend during backend development will be detected [stretch goal but the sooner the better] Add non-regression snapshot tests Sep 1, 2023
@github-project-automation github-project-automation bot moved this to Incoming in AWS Datasources Sep 4, 2023
@fridgepoet fridgepoet moved this from Incoming to Next in AWS Datasources Sep 4, 2023
@fridgepoet fridgepoet self-assigned this Sep 4, 2023
@fridgepoet fridgepoet moved this from Next to In Progress in AWS Datasources Sep 5, 2023
@fridgepoet fridgepoet changed the title [stretch goal but the sooner the better] Add non-regression snapshot tests [stretch goal but the sooner the better] Investigate non-regression snapshot tests Sep 5, 2023
@fridgepoet fridgepoet mentioned this issue Sep 8, 2023
Merged
@fridgepoet
Copy link
Member Author

Have decided to add tests in upcoming PRs.

@github-project-automation github-project-automation bot moved this from In Progress to Done in AWS Datasources Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fridgepoet fridgepoet

Labels
effort/small
Projects
AWS Datasources
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fridgepoet