Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Create plugin should add a dependabot config to regularly update grafana-plugin-sdk-go package #1088

Closed
1 of 5 tasks
ivanahuckova opened this issue Sep 2, 2024 · 4 comments · Fixed by #1143
Closed
1 of 5 tasks
Assignees
Labels
enhancement New feature or request released This issue/pull request has been released.

Comments

@ivanahuckova
Copy link
Member

ivanahuckova commented Sep 2, 2024

Which areas does this feature request relate to

  • Create Plugin
  • Sign Plugin
  • Plugin E2E
  • Plugin Meta Extractor
  • Documentation

Problem

We are adding to plugin repositories dependabot config that checks weekly, if grafana-plugin-sdk-go was updated and if so, creates a PR with updated version. This helps with making sure that plugins are up to date with new sdk, which currently is an issue.

Related to https://github.com/grafana/data-sources/issues/63

Solution

Example of the dependabot config: https://github.com/grafana/grafana-infinity-datasource/blob/main/.github/dependabot.yml

version: 2
updates:
  - package-ecosystem: "gomod"
    directory: "/"
    schedule:
      interval: "weekly"
    allow:
      # Keep the sdk modules up-to-date
      - dependency-name: "github.com/grafana/grafana-plugin-sdk-go"
        dependency-type: "all"
    commit-message:
      prefix: "Upgrade grafana-plugin-sdk-go "
      include: "scope"

While here I am focusing on plugin-sdk, we could think further if there are other packages/dependencies, that we would like to regularly update.

@ivanahuckova ivanahuckova added the enhancement New feature or request label Sep 2, 2024
@ivanahuckova
Copy link
Member Author

ivanahuckova commented Sep 2, 2024

fyi @aangelisc and @wbrowne

@tolzhabayev
Copy link
Collaborator

I think we should maybe consider looking into extending the grafana/create-plugin update command to also bump the SDK package and ran the update instead of dependabot.

@tolzhabayev tolzhabayev changed the title Feat: Create plugin should add a deoendabot config to regularly update grafana-plugin-sdk-go package Feat: Create plugin should add a dependabot config to regularly update grafana-plugin-sdk-go package Sep 3, 2024
@ivanahuckova
Copy link
Member Author

I think we should maybe consider looking into extending the grafana/create-plugin update command to also bump the SDK package and ran the update instead of dependabot.

Great idea!

@grafana-plugins-platform-bot
Copy link

🚀 Issue was released in @grafana/create-plugin@5.4.0 🚀

@grafana-plugins-platform-bot grafana-plugins-platform-bot bot added the released This issue/pull request has been released. label Sep 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released This issue/pull request has been released.
Projects
Status: 🚀 Shipped
Development

Successfully merging a pull request may close this issue.

3 participants