Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate: Refactor npm dependency updates #122

Closed
jackw opened this issue Oct 27, 2022 · 0 comments
Closed

Migrate: Refactor npm dependency updates #122

jackw opened this issue Oct 27, 2022 · 0 comments
Labels
create-plugin related to the create-plugin tool

Comments

@jackw
Copy link
Collaborator

jackw commented Oct 27, 2022

Having merged #119 I think we should refactor how we're introducing the npm dependencies of create-plugin during a plugin migration. Right now we depend on the package.json template for grafana dependencies and then delete certain grafana dependencies that might be in undesired locations (devDeps for example). This made the code required to not change grafana dependencies in the linked PR feel like a band aid.
@jackw jackw added the create-plugin related to the create-plugin tool label Nov 17, 2022
@academo academo mentioned this issue Mar 3, 2023
Closed
@academo academo self-assigned this Mar 7, 2023
@academo academo moved this from 📬 Uncategorized to 📅 Planned in Plugins Platform / Grafana Community Mar 7, 2023
@academo academo moved this from 📅 Planned to 🧑‍💻 In development (Limit 6) in Plugins Platform / Grafana Community Mar 7, 2023
@academo academo removed their assignment Mar 29, 2023
@academo academo moved this from 🧑‍💻 In development (Limit 6) to 📅 Planned in Plugins Platform / Grafana Community Mar 29, 2023
@github-actions github-actions bot added the stale label Aug 9, 2023
@tolzhabayev tolzhabayev moved this from 📅 Planned to 💡 Ideation in Plugins Platform / Grafana Community Aug 9, 2023
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 23, 2023
@github-project-automation github-project-automation bot moved this from 💡 Ideation to 🚀 Shipped in Plugins Platform / Grafana Community Aug 23, 2023
@jackw jackw removed the stale label Feb 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
create-plugin related to the create-plugin tool
Projects
Plugins Platform / Grafana Community
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Refactor npm dependencies update grafana/plugin-tools
2 participants
@jackw @academo