Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

godeltaprof (and golang runtime) sometimes incorrectly outputs generic function names #82

Closed
korniltsev opened this issue Dec 4, 2023 · 2 comments · Fixed by #106
Closed

godeltaprof (and golang runtime) sometimes incorrectly outputs generic function names #82

korniltsev opened this issue Dec 4, 2023 · 2 comments · Fixed by #106

Comments

@korniltsev
Copy link
Collaborator

See golang/go#64528 for more info
@korniltsev korniltsev changed the title godeltaprof (and golangruntime) sometimes incorrectly outputs generic function names godeltaprof (and golang runtime) sometimes incorrectly outputs generic function names Dec 4, 2023
@simonswine
Copy link

simonswine commented Feb 14, 2024 •
edited
Loading

@korniltsev fixed this upstream, so go 1.21.6 or newer should no longer have the problem

@korniltsev
Copy link
Collaborator Author

I think we should backport those changes as we have a fork/copy of src/runtime/pprof/proto.go

@korniltsev korniltsev reopened this Feb 15, 2024
@korniltsev korniltsev mentioned this issue May 21, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(godeltaprof): incorrect function names for generics functions grafana/pyroscope-go
2 participants
@simonswine @korniltsev