Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add warning / mechanism for supporting older Typescript versions for Flamegraph #1346

Closed
Rperry2174 opened this issue Aug 3, 2022 · 1 comment
Closed

Add warning / mechanism for supporting older Typescript versions for Flamegraph #1346

Rperry2174 opened this issue Aug 3, 2022 · 1 comment
Assignees
@eh-am

Comments

@Rperry2174
Copy link
Contributor

Rperry2174 commented Aug 3, 2022 •
edited
Loading

In #1339 we made some changes to be able to support older typescript version with our flamegraph component (particularly for Jaeger usage in this case)..

We should come up with a way to either alert us in CI if we use a Typescript feature that is not supported in typescript 3 or a way to convert typescript 4 to typescript 3

This may be an option: https://github.com/sandersn/downlevel-dts
@Rperry2174 Rperry2174 changed the title Add warning / mechanism for supporting older Typescript versions Add warning / mechanism for supporting older Typescript versions for Flamegraph Aug 3, 2022
@eh-am eh-am mentioned this issue Aug 3, 2022
Closed
@eh-am
Copy link
Collaborator

eh-am commented Aug 4, 2022

Implemented in #1348

@eh-am eh-am closed this as completed Aug 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eh-am eh-am

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eh-am @Rperry2174