Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add apps page to the frontend #1416

Closed
petethepig opened this issue Aug 17, 2022 · 2 comments
Closed

Add apps page to the frontend #1416

petethepig opened this issue Aug 17, 2022 · 2 comments
Assignees
Labels
frontend Mostly JS code

Comments

@petethepig
Copy link
Member

We need a page that would list all apps and have delete buttons. It should go under Settings. The route should be /settings/apps.

For now we should just make it a table with all the apps and one button (delete). We should make it look similar to other similar pages, e.g /settings/users. I know @dogfrogfog is working on a unified table component, it's a good idea to use that one here.

Regarding the backend. We have 2 API endpoints, one for listing apps:

GET /api/apps

One for deleting apps, it requires a DELETE method and takes a JSON with one field (name):

DELETE /api/apps
{
  "name": "pyroscope.server.cpu"
}

These routes are authentication protected, so to use them, run pyroscope with the following arguments:

PYROSCOPE_AUTH_INTERNAL_ENABLED=true make dev

You can then log into pyroscope using admin/admin combination.

@petethepig petethepig added the frontend Mostly JS code label Aug 17, 2022
@eh-am eh-am changed the title Create apps page on the frontend Add apps page on the frontend Aug 17, 2022
@eh-am eh-am changed the title Add apps page on the frontend Add apps page to the frontend Aug 17, 2022
@eh-am
Copy link
Collaborator

eh-am commented Aug 17, 2022

Let's not forget to add a warning/confirmation when deleting apps. Similar to
https://github.com/pyroscope-io/pyroscope/blob/main/pkg/admin/cli.go#L62-L75

@Rperry2174
Copy link
Contributor

completed in #1424

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Mostly JS code
Projects
None yet
Development

No branches or pull requests

4 participants