Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OAuth Authentication #262

Closed
3 tasks
petethepig opened this issue Jun 24, 2021 · 2 comments · Fixed by #272
Closed
3 tasks

OAuth Authentication #262

petethepig opened this issue Jun 24, 2021 · 2 comments · Fixed by #272
Labels
backend Mostly go code

Comments

@petethepig
Copy link
Member

petethepig commented Jun 24, 2021

Problem

Currently there's no authentication mechanism in pyroscope. Users are asking about it and we need to add something soon.

Proposed Solution

I'm thinking we could implement OAuth relatively quickly. There's golang.org/x/oauth2 module that provides OAuth functionality.

There's also https://github.com/dghubble/gologin which seems to combine a few of these.

Services we should add support for now

  • Google
  • GitHub
  • GitLab

Additional Requirements

We need to make sure that whatever we come up with we can extend with extra functionality later. For example, later down the line we'll probably want to add support for things like:

  • basic Auth
  • SAML, LDAP
  • custom email / password authentication with some local db
@petethepig petethepig added the backend Mostly go code label Jun 24, 2021
@a-donskoy
Copy link

Would be nice to get some different levels of permissions or option to choose which user or team (for example github one) should have access to which type of data or project. It will cover cases when multiply teams working on different projects which we expose on a same pyroscope setup

@Skemba Skemba linked a pull request Jul 5, 2021 that will close this issue
@dreuse
Copy link

dreuse commented Jun 27, 2024

Is there any documentation on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Mostly go code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants