-
Notifications
You must be signed in to change notification settings - Fork 611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(v2): metastore index #3586
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleks-p
force-pushed
the
v2/metastore-index
branch
2 times, most recently
from
September 26, 2024 12:32
f53bf79
to
af472ea
Compare
aleks-p
force-pushed
the
v2/metastore-index
branch
from
October 1, 2024 18:24
5755b3e
to
c5f46ce
Compare
kolesnikovae
reviewed
Oct 2, 2024
aleks-p
force-pushed
the
v2/metastore-index
branch
from
October 4, 2024 17:32
c5f46ce
to
76c8418
Compare
aleks-p
force-pushed
the
v2/metastore-index
branch
from
October 4, 2024 17:40
c176eb5
to
4270517
Compare
kolesnikovae
approved these changes
Oct 7, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work, @aleks-p! Thanks for taking care of this!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces the
metastore/index
package which adds a time-partitioned block index and integrates it with the existing flows for adding, compacting and querying blocks. This is a draft with a few parts missing (some of which are marked with FIXME and TODO comments).This is a breaking change meant for the v2 work stream. Once merged existing blocks will not be reachable.