Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(push-to-gcs): allow setting 'predefinedAcl' on objects when uploading #193

Merged
merged 7 commits into from
Jul 22, 2024
Merged

feat(push-to-gcs): allow setting 'predefinedAcl' on objects when uploading #193

merged 7 commits into from
Jul 22, 2024

Conversation

twu
Copy link
Contributor

@twu twu commented Jul 22, 2024

Proposed Changes

@twu twu requested a review from a team as a code owner July 22, 2024 09:42
@CLAassistant
Copy link

CLAassistant commented Jul 22, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@twu twu changed the title feat(push-to-gcs): Allow setting 'predefinedAcl' on objects when uploading feat(push-to-gcs): allow setting 'predefinedAcl' on objects when uploading Jul 22, 2024
iainlane
iainlane reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

This looks like a sensible addition to me.

Could you add an example and update the table in the README.md in this directory too, please?

@twu twu requested a review from iainlane July 22, 2024 10:51
iainlane
iainlane approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@iainlane iainlane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

actions/push-to-gcs/README.md Outdated Show resolved Hide resolved
actions/push-to-gcs/README.md Outdated Show resolved Hide resolved
twu and others added 2 commits July 22, 2024 14:15
@twu @iainlane
Update actions/push-to-gcs/README.md
d1bb596 
Co-authored-by: Iain Lane <iain@orangesquash.org.uk>
@twu
Use named reference-style links
dde63a2
@iainlane iainlane added this pull request to the merge queue Jul 22, 2024
Merged via the queue into grafana:main with commit 97e6191 Jul 22, 2024
7 checks passed
@github-actions github-actions bot mentioned this pull request Jul 22, 2024
Closed
@twu twu deleted the twu/make-predefined-acl-configurable branch July 22, 2024 13:56
This was referenced Sep 25, 2024
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iainlane iainlane iainlane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@twu @CLAassistant @iainlane