chore: hash connectionArgs when used as cache key (#199)

Author: asimpson

datasource.go

@@ -2,6 +2,7 @@ package sqlds
 
 import (
 	"context"
+	"crypto/sha256"
 	"database/sql"
 	"encoding/json"
 	"errors"
@@ -41,7 +42,8 @@ func defaultKey(datasourceUID string) string {
 }
 
 func keyWithConnectionArgs(datasourceUID string, connArgs json.RawMessage) string {
-	return fmt.Sprintf("%s-%s", datasourceUID, string(connArgs))
+	connectionArgsHash := sha256.Sum256(connArgs)
+	return fmt.Sprintf("%s-%x", datasourceUID, connectionArgsHash)
 }
 
 type dbConnection struct {

datasource_connect_test.go

@@ -64,15 +64,15 @@ func Test_getDBConnectionFromQuery(t *testing.T) {
 			desc:        "it should return the cached connection for the given args",
 			dsUID:       "uid1",
 			args:        "foo",
-			expectedKey: "uid1-foo",
+			expectedKey: "uid1-2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae",
 			existingDB:  db2,
 			expectedDB:  db2,
 		},
 		{
 			desc:        "it should create a new connection with the given args",
 			dsUID:       "uid1",
 			args:        "foo",
-			expectedKey: "uid1-foo",
+			expectedKey: "uid1-2c26b46b68ffc68ff99b453c1d30413413422d706483bfa0f98a5e886266e7ae",
 			expectedDB:  db3,
 		},
 	}