Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove dynamic and unused data-fs-element attributes #941

Merged
merged 1 commit into from
Sep 23, 2024
Merged

fix: remove dynamic and unused data-fs-element attributes #941

merged 1 commit into from
Sep 23, 2024

Conversation

ckbedwell
Copy link
Contributor

Problem

We've had reports that the way we are generating data-fs-elements is causing us to hit a limit in FullStory.

Solution

Remove two of the main offenders in the check creation flow:

  1. The request headers data-fs-element attribute
  2. The MultiHttpCollapse data-fs-element attribute

@ckbedwell ckbedwell requested a review from a team as a code owner September 23, 2024 11:49
@ckbedwell ckbedwell merged commit d1b11ae into main Sep 23, 2024
5 checks passed
@ckbedwell ckbedwell deleted the fix/remove-fs-elements branch September 23, 2024 13:50
@sm-release-app sm-release-app bot mentioned this pull request Oct 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VikaCep VikaCep VikaCep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckbedwell @VikaCep