Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tk apply diff is not colored anymore #209

Closed
pracucci opened this issue Feb 12, 2020 · 3 comments · Fixed by #216
Closed

tk apply diff is not colored anymore #209

pracucci opened this issue Feb 12, 2020 · 3 comments · Fixed by #216
Labels
component/cli Command Line Interface kind/bug Something isn't working

Comments

@pracucci
Copy link

I've just upgraded to tanka master and noticed that the diff displayed by tk apply is not colored anymore. The previous version I was running was 0.5 and the output was colored there.

@pstibrany
Copy link
Member

I'd prefer an option (ideally one that can be set via env. variable, so that I can turn it off globally) for this. Tanka's built-in coloring always messed up my terminal.

@pracucci
Copy link
Author

Tanka's built-in coloring always messed up my terminal.

In my experience tk diff is messing up with colors due to the paging, but not tk apply.

@rfratto
Copy link
Member

rfratto commented Feb 12, 2020

In my experience tk diff is messing up with colors due to the paging, but not tk apply.

FYI, #210 should fix the problems with colors in tk diff.

@sh0rez sh0rez added component/cli Command Line Interface kind/bug Something isn't working labels Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/cli Command Line Interface kind/bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants